PMM-12252 Removing Alertmanager from advisors dependencies #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
- Coverage 42.86% 42.77% -0.10%
==========================================
Files 383 383
Lines 48248 48126 -122
==========================================
- Hits 20681 20584 -97
+ Misses 25629 25604 -25
Partials 1938 1938
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
artemgavrilov
changed the title
artemgavrilov
changed the title
artemgavrilov
changed the title
artemgavrilov
requested review from
ademidoff and
idoqo
and removed request for
a team
BupycHuk
reviewed
Jun 23, 2023
| @@ -36,20 +29,13 @@ type registry struct { | |||
| rw sync.RWMutex | |||
| // Results stored grouped by interval and by check name. It allows us to remove results for specific group. | |||
| checkResults map[check.Interval]map[string][]services.CheckResult | |||
There was a problem hiding this comment.
Can we not store data in memory? We need to rewrite it for HA purposes.
There was a problem hiding this comment.
We can, but in scope of another ticket. This one just removes AM.
ademidoff
approved these changes
Jun 27, 2023
idoqo
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12252
Link to the Feature Build: SUBMODULES-3178
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: