PXC-3546: [MTR] Fix failing keyring_vault sute tests #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins is not configured to be used with the vault probably. I used Hashicorp on the local machine. |
|
|
||
| --replace_result $MYSQLTEST_VARDIR MYSQLTEST_VARDIR | ||
| eval SET @@global.keyring_vault_config="$vault_conf_file"; | ||
| --let $keyring_restart_param = restart: $KEYRING_VAULT_PLUGIN_OPT $KEYRING_VAULT_PLUGIN_EARLY_LOAD --keyring_vault_config=$vault_conf_file --innodb-sort-buffer-size=64k --innodb_encrypt_online_alter_logs=ON |
There was a problem hiding this comment.
This test is inherited from PS. How it is that it works for PS?
https://github.com/percona/percona-server/blob/c676f75d020dd0a56716f9dd6c7526c15818cf74/plugin/keyring_vault/tests/mtr/innodb_online_alter_encryption.test#L25
There was a problem hiding this comment.
Updated the commit message that explains, why the suite works in Percona Server.
https://jira.percona.com/browse/PXC-3546 All tests had the same cause of failure: keyring_vault plugin installation requires keyring_vault_config variable with valid data in the file. Setting this variable at the time of the test run is not possible as the file is generated within the test itself. Restarting the server solved the problem. This breaking change has been made intentionally in PXC-2135 (commit b58c1d1). Before the change plugin was loaded without valid or any keyring_vault_config file, so we could SET that plugin variable. Reasons for deletion: - keyring_vault_timeout: relies on keyring_vault_config with invalid data, which is now impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PXC-3546
All tests had the same cause of failure: keyring_vault plugin installation requires keyring_vault_config variable with valid data in the file. Setting this variable at the time of the test run is not possible as the file is generated within the test itself. Restarting the server solved the problem.
This breaking change has been made intentionally in PXC-2135 (commit b58c1d1). Before the change plugin was loaded without valid or any keyring_vault_config file, so we could SET that plugin variable.
Reasons for deletion: