PSMDB-810 improve logging #695
Conversation
| log() << "Hot backup copying {} bytes from '{}' to '{}'"_format( | ||
| fsize, srcFile.string(), destFile.string()); |
There was a problem hiding this comment.
| log() << "Hot backup copying {} bytes from '{}' to '{}'"_format( | |
| fsize, srcFile.string(), destFile.string()); | |
| log() << "Beginning copy of {}/{} files in backup snapshot: {}, {} bytes"_format( | |
| fcCtr++, filesList.size(), srcFile.filename(), fsize); |
(The fcCtr variable needs to be defined just a bit above of course.)
As for the destFile I think the destination directory only needs to be shown once as the backup process begins. (The destination incidentally also appears in the argument values of the "command: createBackup" log message when it finishes.)
There was a problem hiding this comment.
I wish we could print the user-recognizable collection or index namespace string, when a file is a user-data table, but I don't find a map of "idents" -> namespaces. Only private member "NSToIdentMap _idents;" in the DurableCatalogImpl class, so we'd also have to change that class to access.
| } else { | ||
| log() << "Source file size is: {} bytes"_format(fs::file_size(srcFile)); | ||
| } | ||
|
|
There was a problem hiding this comment.
| } else { | |
| log() << "Source file size is: {} bytes"_format(fs::file_size(srcFile)); | |
| } | |
| } | |
Truncating the byte size log line from here because the preceding edit suggestion would include it there.
There was a problem hiding this comment.
My idea was to show current size of the file. It may be different from the size reported in another message (that size is captured when file list is generated)
There was a problem hiding this comment.
Thanks for catching the fcCtr increment bug.
There was a problem hiding this comment.
Regarding showing the size of the file it is true, it might become notably bigger during the backup. And that is so interesting to DBAs worried about file size growth that I first drafted an edit where it would warn() (not log) if the file size had grown (> +10% && > +100MB).
I don't think it's helpful for users to just be informed what the size is if it is not the same size as what is copied. I think they will see it as an error and report it.
But then I discarded that draft because the $backupCursor work will probably require us doing this all again, didn't seem worthwhile now.
| } else { | ||
| log() << "Source file size is: {} bytes"_format(fs::file_size(srcFile)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for catching the fcCtr increment bug.
| } else { | ||
| log() << "Source file size is: {} bytes"_format(fs::file_size(srcFile)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Regarding showing the size of the file it is true, it might become notably bigger during the backup. And that is so interesting to DBAs worried about file size growth that I first drafted an edit where it would warn() (not log) if the file size had grown (> +10% && > +100MB).
I don't think it's helpful for users to just be informed what the size is if it is not the same size as what is copied. I think they will see it as an error and report it.
But then I discarded that draft because the $backupCursor work will probably require us doing this all again, didn't seem worthwhile now.
No description provided.