Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes after the first install of PBM #158

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

boris-ilijic
Copy link
Member

These are minor issues that I noticed during my first installation on local machine using docker. Please see commit message for additional explanation, if needed.

Copy link

render bot commented Mar 4, 2024

docs/details/cli.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nastena1606 nastena1606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!. Changed html to md in links since we're referring to source files which are then translated to respective format duting doc build

docs/install/configure-authentication.md Outdated Show resolved Hide resolved
boris-ilijic and others added 2 commits March 4, 2024 18:18
Co-authored-by: Anastasia Alexandrova <[email protected]>
Co-authored-by: Anastasia Alexandrova <[email protected]>
@boris-ilijic
Copy link
Member Author

@nastena1606 Good catch, wasn't aware of that. Should be fixed now.

@nastena1606 nastena1606 self-requested a review March 4, 2024 17:21
Copy link
Collaborator

@nastena1606 nastena1606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@nastena1606 nastena1606 merged commit cfd075d into main Mar 4, 2024
2 checks passed
@boris-ilijic boris-ilijic deleted the fixes-noticed-during-first-install branch March 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants