Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip totalCollectionsCount, when not needed #609

Closed
wants to merge 4 commits into from
Closed

Skip totalCollectionsCount, when not needed #609

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2022

Sadly #590 does not solve the Problem from #562. Here is my PR for the solution.


  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.

@ghost ghost self-requested a review as a code owner December 23, 2022 12:25
@ghost ghost requested review from ShashankSinha252 and tshcherban and removed request for a team December 23, 2022 12:25
@it-percona-cla
Copy link

it-percona-cla commented Dec 23, 2022

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link
Author

ghost commented Jan 4, 2023

I fixed the error, can we run the action again?

@ghost ghost closed this Apr 7, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants