Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gopsutil for Apple silicon mac compatibility of go test #342

Merged

Conversation

hiroshi
Copy link
Contributor

@hiroshi hiroshi commented Sep 19, 2021

from #295 (comment)

This will fix Apple silicon mac imcompatibility issue of go test.
Image from Gyazo


  • Tests passed.
  • Fix conflicts with target branch.
  • Update jira ticket description if needed.
  • Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

When all checks have passed and code is ready for the review, bot should add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forums and Discord.

@hiroshi hiroshi mentioned this pull request Sep 19, 2021
6 tasks
@hiroshi hiroshi changed the title Update gopsutil for Apple silicon mac compatibility of make test Update gopsutil for Apple silicon mac compatibility of go test Sep 19, 2021
@hiroshi hiroshi marked this pull request as ready for review September 19, 2021 12:56
@hiroshi
Copy link
Contributor Author

hiroshi commented Sep 19, 2021

The test was started after this change, but it failed by another problem. I'm not sure what's wrong with it.
Image from Gyazo

@denisok denisok requested review from a team, percona-csalguero and JiriCtvrtka and removed request for a team September 20, 2021 08:43
@percona-csalguero percona-csalguero changed the title Update gopsutil for Apple silicon mac compatibility of go test Upgrade gopsutil for Apple silicon mac compatibility of go test Sep 20, 2021
@percona-csalguero
Copy link
Contributor

Online tests are passing and also locally:

make test 
go test -v -timeout 30s ./...
go: downloading golang.org/x/sys v0.0.0-20210816074244-15123e1e1f71
=== RUN   TestBuildExporter
time="2021-09-20T10:08:32-03:00" level=debug msg="Compatible mode: true"
time="2021-09-20T10:08:32-03:00" level=debug msg="Connection URI: mongodb://usr:[email protected]/"
--- PASS: TestBuildExporter (0.00s)
PASS
ok      github.com/percona/mongodb_exporter     0.006s
=== RUN   TestCollStatsCollector
--- PASS: TestCollStatsCollector (0.04s)
=== RUN   TestDBStatsCollector
--- PASS: TestDBStatsCollector (0.04s)
=== RUN   TestDebug
--- PASS: TestDebug (0.00s)
=== RUN   TestDiagnosticDataCollector
--- PASS: TestDiagnosticDataCollector (0.03s)
=== RUN   TestAllDiagnosticDataCollectorMetrics
--- PASS: TestAllDiagnosticDataCollectorMetrics (0.04s)
=== RUN   TestConnect
=== RUN   TestConnect/Connect_without_SSL
=== RUN   TestConnect/Test_per-request_connection
=== RUN   TestConnect/Test_global_connection
--- PASS: TestConnect (0.37s)
    --- PASS: TestConnect/Connect_without_SSL (0.01s)
    --- PASS: TestConnect/Test_per-request_connection (0.23s)
    --- PASS: TestConnect/Test_global_connection (0.13s)
=== RUN   TestMongoS
time="2021-09-20T10:08:33-03:00" level=error msg="cannot get replSetGetStatus: replSetGetStatus is not supported through mongos"
--- PASS: TestMongoS (0.02s)
=== RUN   TestGeneralCollector
time="2021-09-20T10:08:33-03:00" level=error msg="error while checking mongodb connection: client is disconnected. mongo_up is set to 0"
--- PASS: TestGeneralCollector (0.00s)
=== RUN   TestIndexStatsCollector
--- PASS: TestIndexStatsCollector (0.06s)
=== RUN   TestSanitize
=== RUN   TestSanitize/With_building
=== RUN   TestSanitize/Without_building
--- PASS: TestSanitize (0.00s)
    --- PASS: TestSanitize/With_building (0.00s)
    --- PASS: TestSanitize/Without_building (0.00s)
=== RUN   TestMetricName
--- PASS: TestMetricName (0.00s)
=== RUN   TestPrometeusize
--- PASS: TestPrometeusize (0.00s)
=== RUN   TestMakeRawMetric
--- PASS: TestMakeRawMetric (0.00s)
=== RUN   TestRawToCompatibleRawMetric
--- PASS: TestRawToCompatibleRawMetric (0.00s)
=== RUN   TestReplsetStatusCollector
--- PASS: TestReplsetStatusCollector (0.00s)
=== RUN   TestReplsetStatusCollectorNoSharding
--- PASS: TestReplsetStatusCollectorNoSharding (0.00s)
=== RUN   TestSecondaryLag
    secondary_lag_test.go:56: This is failing in GitHub actions. Cannot make secondary to lag behind
--- SKIP: TestSecondaryLag (0.00s)
=== RUN   TestServerStatusDataCollector
--- PASS: TestServerStatusDataCollector (0.02s)
=== RUN   TestTopologyLabels
--- PASS: TestTopologyLabels (0.00s)
=== RUN   TestWalkTo
--- PASS: TestWalkTo (0.00s)
=== RUN   TestMakeLockMetric
--- PASS: TestMakeLockMetric (0.00s)
=== RUN   TestAddLocksMetrics
--- PASS: TestAddLocksMetrics (0.00s)
=== RUN   TestSumMetrics
=== RUN   TestSumMetrics/timeAcquire
=== RUN   TestSumMetrics/timeAcquire#01
--- PASS: TestSumMetrics (0.00s)
    --- PASS: TestSumMetrics/timeAcquire (0.00s)
    --- PASS: TestSumMetrics/timeAcquire#01 (0.00s)
=== RUN   TestCreateOldMetricFromNew
--- PASS: TestCreateOldMetricFromNew (0.00s)
PASS
ok      github.com/percona/mongodb_exporter/exporter    0.632s
?       github.com/percona/mongodb_exporter/internal/tu [no test files]

@percona-csalguero percona-csalguero merged commit 0fec706 into percona:main Sep 20, 2021
@hiroshi hiroshi deleted the update-gopsutil-for-apple-silicon branch September 21, 2021 00:16
@hiroshi
Copy link
Contributor Author

hiroshi commented Sep 21, 2021

Thank you for accepting this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants