Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKLOG-39648] Dashboard interface is cropped on the right side #5508

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

singletonc
Copy link
Contributor

@singletonc singletonc commented Jan 27, 2024

To be merged with pentaho/pentaho-commons-gwt-modules#1019

  • Fix tab-width when Solution Browser is present
  • Ensure fix works when SolutionBrowser isn't present and hasn't loaded
  • Add setElementWidth helper method in CssUtils to bypass restrictions on GWT style helper methods

The only way I could figure out how to get a horizontal scroll is by setting a width value in .css file or in-line style attribute.

GWT style helper methods do not like units that aren't px, so, I created a helper method in lieu of rewrapping GWT classes down to Style

- Fix tab-width when Solution Browser is present
- Ensure fix works when SolutionBrowser isn't present and hasn't loaded
@singletonc singletonc requested a review from a team as a code owner January 27, 2024 00:22
@buildguy

This comment has been minimized.

@buildguy
Copy link
Collaborator

❌ Build failed in 3m 33s

Build command:

mvn clean verify -B -e -Daudit -amd -pl user-console

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message

@rmansoor rmansoor merged commit a6a883c into pentaho:master Jan 28, 2024
2 of 4 checks passed
@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants