Use Bowl for all VFS API requests #9579
Conversation
abryant-hv
force-pushed
the
BACKLOG-41094
branch
from
047f07b
to
c9f1e71
Compare
| FileObject destFile = KettleVFS.getFileObject( dest ); | ||
| IKettleVFS vfs = KettleVFS.getInstance( DefaultBowl.getInstance() ); | ||
| FileObject srcFile = vfs.getFileObject( src ); | ||
| FileObject destFile = vfs.getFileObject( dest ); | ||
| try ( InputStream in = KettleVFS.getInputStream( srcFile ); |
There was a problem hiding this comment.
The getOutputStream() is using the kettleVFS with Bowl and getInputStream() does not? Why?
There was a problem hiding this comment.
getInputStream( FileObject ) is a static helper method. It doesn't do anything with the bowl, so isn't on IKettleVFS and remains on KettleVFS. There are several methods like this.
| @@ -150,8 +152,8 @@ public Result execute( final Params params, String[] arguments ) throws Throwabl | |||
| // Try to load the transformation from file, even if it failed to load from the repository | |||
| // You could implement some fail-over mechanism this way. | |||
| if ( trans == null ) { | |||
| trans = loadTransFromFilesystem( params.getLocalInitialDir(), params.getLocalFile(), params.getLocalJarFile(), | |||
| params.getBase64Zip() ); | |||
| trans = loadTransFromFilesystem( DefaultBowl.getInstance(), params.getLocalInitialDir(), | |||
There was a problem hiding this comment.
This can potentially create problems. In the Pan/Kitchen.java, we are taking the project parameter to figure out the what is the ProjctBowl. This project bowl will be set in the TransMeta/JobMeta when the loadXml is called. But here, we are initializing TransMeta with the defaultBowl.
There was a problem hiding this comment.
yeah, this will need to be modified by BACKLOG-42187
Note to reviewers: split into two commits, with the most interesting API changes in the first commit.