Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRD-6159] - upgrading the poi, commons-io, commons-compiler jars and… #9442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PRD-6159] - upgrading the poi, commons-io, commons-compiler jars and… #9442

wants to merge 1 commit into from

Conversation

lsaikrishna89
Copy link
Contributor

… upgraded the code accordingly

@lsaikrishna89 lsaikrishna89 requested a review from a team as a code owner June 26, 2024 10:31
@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)
Failed condition 61.3% 61.3% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@buildguy
Copy link
Collaborator

⚠️ Build finished in 36m 28s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
assemblies/client,engine,plugins/excel/core,plugins/pentaho-reporting/assemblies/plugin,plugins/xml

⛔ Failed Tests

⛈️ 3 test(s) failed:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterFullTest.testDataValidationExtension (click to expand)


java.lang.IllegalArgumentException: Attempting to write a row[1] in the range [0,9] that is already written to disk.
Attempting to write a row[1] in the range [0,9] that is already written to disk.

org.pentaho.di.trans.steps.excelwriter.ExcelWriterFullTest.testWriteStreamingTemplate (click to expand)


java.lang.IllegalArgumentException: Attempting to write a row[1] in the range [0,9] that is already written to disk.
Attempting to write a row[1] in the range [0,9] that is already written to disk.

org.pentaho.di.trans.steps.excelwriter.ExcelWriterFullTest.testWriteStreamingTemplateOutFields (click to expand)


java.lang.IllegalArgumentException: Attempting to write a row[1] in the range [0,9] that is already written to disk.
Attempting to write a row[1] in the range [0,9] that is already written to disk.

Tests run: 2442, Failures: 3, Skipped: 13    Test Results

ℹ️ This is an automatic message

tgf
tgf reviewed Jun 26, 2024
View reviewed changes
plugins/excel/core/src/main/java/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java
@@ -691,6 +694,11 @@ public void prepareNextOutputFile() throws KettleException {
// In that case, one needs to initialize it later, after writing header/template, because
// SXSSFWorkbook can't read/rewrite existing data, only append.
data.wb = new XSSFWorkbook( inputStream );
// As the file is being created and the rows are being initialized,
// so there will be no read and re-write operation for the first time, creating SXSSFWorkbook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be if you are writing over a template, hence the test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgf tgf tgf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsaikrishna89 @buildguy @tgf