BACKLOG-37664 POC to make pentaho server work with vfs metastore #8894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abryant-hv
approved these changes
May 18, 2023
niehusa
reviewed
May 18, 2023
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/PurRepository.java
Outdated
Show resolved
Hide resolved
niehusa
reviewed
May 18, 2023
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/PurRepository.java
Outdated
Show resolved
Hide resolved
niehusa
approved these changes
May 18, 2023
pdesai16
reviewed
May 18, 2023
| super(); | ||
| initSharedObjectAssemblerMap(); | ||
| Collection<MetastoreLocatorOsgi> metastoreLocators = PluginServiceLoader.loadServices( MetastoreLocatorOsgi.class ); |
There was a problem hiding this comment.
This is perfectly fine for POC, but did you ran into some problem looking for MetastoreLocator instead
There was a problem hiding this comment.
Yes using metastore locator instead of the osgi one required a new dependency that caused problems
There was a problem hiding this comment.
Oh yes, I remember now. I was able to look up MetastoreLocator and added dependency for pentaho-metastore-locator-api in pom.xml and it worked fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.