Skip to content

Commit

Permalink
Add changes to fix issues running the Spacewalk client in Kubernetes (#…
Browse files Browse the repository at this point in the history
…519)

* Change/remove `backoff::retry()` usage in runner

* Remove `backoff` from error.rs

* Manually implement backoff behaviour

* Fix build error

* Formatting

* Refactor error messages

* Restore original logic with max retry interval

* Remove import

* Run `cargo +nightly-2024-02-09 fmt --all`

* Run cargo fmt with nightly

* Add logic to reopen the runner websocket

* Add debug logs

* Fix compile issues

* Add test for the backoff/retry logic

* Simplify retry logic

* Use test for both

* Remove unfinished test case and refactor

* fix trailing semicolons

* Refactor error handling around `try_get_release()`

* Remove patch statement for `ahash` again

* Remove patch statement for `ahash` again

* Replace references to `nightly-02-09` with `nightly-04-18`

* Don't log message for each retry

* Change `max-parallel` to `2`
as there is no reason not to parallelize the jobs anymore

* Add some 'allow' statements for clippy

* revert version to 2024-02-09

---------

Co-authored-by: b-yap <[email protected]>
  • Loading branch information
ebma and b-yap authored May 24, 2024
1 parent 93ddbce commit dae9ddd
Show file tree
Hide file tree
Showing 12 changed files with 550 additions and 449 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
max-parallel: 1
matrix:
os: [ ubuntu-latest, macos-latest ]
rust: [stable, nightly]
rust: [ stable, nightly ]
include:
- os: ubuntu-latest
sccache-path: /home/runner/.cache/sccache
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Setup nightly Rust toolchain
if: matrix.rust == 'nightly'
uses: dtolnay/rust-toolchain@nightly
uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-02-09
components: rustfmt, clippy
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ name: continuous-integration-main
jobs:
ci:
strategy:
max-parallel: 1
max-parallel: 2
matrix:
rust: [stable, nightly]
rust: [ stable, nightly ]
runs-on: ubuntu-20.04
env:
RUST_BACKTRACE: full
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
- name: Setup nightly Rust toolchain
if: matrix.rust == 'nightly'
uses: dtolnay/rust-toolchain@nightly
uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-02-09
components: rustfmt, clippy
Expand Down
Loading

0 comments on commit dae9ddd

Please sign in to comment.