Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and run eslint. #71

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix and run eslint. #71

wants to merge 11 commits into from

Conversation

gianfra-t
Copy link
Contributor

#63

This PR does not include any config changes since the scripts lint and lint:fix are working for me. I just run fix.

@gianfra-t gianfra-t linked an issue Oct 3, 2024 that may be closed by this pull request
@gianfra-t gianfra-t mentioned this pull request Oct 3, 2024
Base automatically changed from fix-foucoco-issues to main October 4, 2024 09:32
@ebma
Copy link
Member

ebma commented Oct 4, 2024

Please don't forget to add reviewers @gianfra-t 😅

@ebma
Copy link
Member

ebma commented Oct 4, 2024

Actually, I tested this locally and I also get an error

$ yarn lint
Invalid option '--ignore-path' - perhaps you meant '--ignore-pattern'?
You're using eslint.config.js, some command line flags are no longer available. Please see https://eslint.org/docs/latest/use/command-line-interface for details.

I did some digging and I think we need to migrate to a new format. It's probably easiest if we just start with the configuration from scratch using the steps here. I already tested it and got 3126 problems (3126 errors, 0 warnings). Maybe we should ignore some of the automatically generated files from eslint as it doesn't really make sense to fix warnings on them as they would need to be fixed again and again.

Can you please add the migration to the new eslint to this PR @gianfra-t?

@gianfra-t
Copy link
Contributor Author

gianfra-t commented Oct 4, 2024

Okay, I will change it. Strange that I don't get an error 🤔 nor a warning.

tsconfigRootDir: './tsconfig.json',
},
},
rules: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pendulum-chain/devs any idea why we had disabled the unused variables rule? I enabled it in the new config here. But I could be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix eslint
2 participants