-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and run eslint. #71
base: main
Are you sure you want to change the base?
Conversation
Also, return `MIN_SAFE_INTEGER` in case of error because it's better to return a small height instead of a large one
Please don't forget to add reviewers @gianfra-t 😅 |
Actually, I tested this locally and I also get an error
I did some digging and I think we need to migrate to a new format. It's probably easiest if we just start with the configuration from scratch using the steps here. I already tested it and got 3126 problems (3126 errors, 0 warnings). Maybe we should ignore some of the automatically generated files from eslint as it doesn't really make sense to fix warnings on them as they would need to be fixed again and again. Can you please add the migration to the new eslint to this PR @gianfra-t? |
Okay, I will change it. Strange that I don't get an error 🤔 nor a warning. |
tsconfigRootDir: './tsconfig.json', | ||
}, | ||
}, | ||
rules: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pendulum-chain/devs any idea why we had disabled the unused variables
rule? I enabled it in the new config here. But I could be missing something.
#63
This PR does not include any config changes since the scripts
lint
andlint:fix
are working for me. I just runfix
.