Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint #63

Open
TorstenStueber opened this issue May 23, 2024 · 4 comments · May be fixed by #71
Open

Fix eslint #63

TorstenStueber opened this issue May 23, 2024 · 4 comments · May be fixed by #71
Assignees
@gianfra-t

Comments

@TorstenStueber
Copy link
Member

TorstenStueber commented May 23, 2024 •
edited
Loading

I observed some errors in the code that would have been easy to prevent with improved linting rules (or linting is set up incorrectly).

This is:

  • definition of variables that are not used
  • (particularly important): forgetting to await the return result of a function (that returns a promise)

Context

This configuration change will make some errors less likely.
@TorstenStueber TorstenStueber changed the title Improve linting rules Fix eslint May 23, 2024
@TorstenStueber
Copy link
Member Author

Seems like the eslint configuration in the project is just outdated and eslint does not work anymore. At least the npm scripts lint and lint:fix don't work.

@TorstenStueber TorstenStueber mentioned this issue May 23, 2024
Merged
@prayagd
Copy link
Contributor

prayagd commented Jun 20, 2024

@TorstenStueber is this a very high priority one and what is it blocking or what functionality does it enable?

@TorstenStueber
Copy link
Member Author

It's a chore to improve code quality and reduce silly errors.

@gianfra-t gianfra-t self-assigned this Oct 3, 2024
@gianfra-t gianfra-t linked a pull request Oct 3, 2024 that will close this issue
Open
@gianfra-t gianfra-t linked a pull request Oct 3, 2024 that will close this issue
Fix and run eslint. #71
Open
@gianfra-t
Copy link
Contributor

Eslint was working for me, so perhaps this was fixed during all this time. Created a PR after running lint:fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gianfra-t gianfra-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and run eslint. pendulum-chain/pendulum-squids
3 participants
@TorstenStueber @prayagd @gianfra-t