Added ability to manually adjust chat delay #30
Conversation
Modified header section to include the twitch chat room selection button which is repurposed to toggle the delay adjustment bar. Added chat delay adjustment bar below the header which is toggled by pressing the repurposed chat room selection button. The chat delay adjustment bar contains: -dropdown to select the number of seconds to adjust by -button to decrease chat delay by the selected number of seconds -display showing the current total delay offset which may be positive or negative -button to increase chat delay by the selected number of seconds Increased 'z-index' property of statusMessage element to ensure it shows above both the header and chat delay sections in all cases. Added 'arrowleft.png' and 'arrowright.png' to 'common/res/' directory. Updated 'Chrome/manifest.json' and 'Firefox/lib/main.js' to include the new resources. Uncommented resources section in 'setup.sh'.
|
Seems to take up a lot of unneeded space. |
|
Yeah, you're right. That's actually how I had it initially when I had just done it for personal use but the main reason I did it this way in the end is to streamline what kind of input can be received from the user thus removing the need for input validation or notifying the user about input errors. I did anticipate that noone would want additional space being taken from the chat area which is why i added the toggle button so you could make adjustments then hide the bar when you're done. If the space is more of a priority then your way is definitely better. If I have some time later after work i'll make some changes, unless you already have? |
|
All up to you, just my thoughts.
|
|
Thanks for your work! I think the UI is not very clear especially for the unexperienced user. Maybe a slider (ranging from 0 to 5 minutes delay) would be a better user experience? Also the delay settings should be somewhat hidden since the default delay is good enough in 90% of the cases. Similar to how Twitch hides the chat settings behind the |
|
Thanks for the slider suggestion! I was also worried that the functionality was a bit hard to understand for a first time user but i wasnt sure of an easier way to implement it. That would be much more intuitive I agree. I will work on that tonight since I have the day off work tomorrow. Im not fully sure what you meant in the second paragraph. The delay settings are currently hidden when the page is loaded and can be shown and hidden by pressing |
|
It would be better to use a settings icon, compared to the group chat icon. On Sun, Oct 18, 2015 at 4:37 PM, Andre Blair [email protected]
|
|
Yes I will change that as well. At the time i was focusing too much on making the header look similar to the normal Twich header but not realizing that using the settings icon would make a lot more sense 😓 |
Replaced chat room button with chat settings button. Replaced button and drop down controls with slider control that allows selection of a delay between 0 and 5 minutes. Removed 'arrowleft.png' and 'arrowright.png' from 'common/res/' directory. Reverted 'Chrome/manifest.json' and 'Firefox/lib/main.js' to original state. Reverted 'setup.sh' to original state. Merged changes from master branch.
|
page loaded: press settings button: changed delay: press settings button: |
|
It is looking better, I wouldn't have a text input, and instead just have text there, and have the slider be the control scheme. It would look better then having that textbox there (assuming that is what that is) Also, are you saving this from page to page? It would be best that the user does not have to change this every time when they refresh the page, either local storage or something of that sort could solve that, but you might already have that implemented. Also, when you are merging to get rid of conflicts, do that in a separate commit from your normal code push. It is tough to wade through and figure out what the programer changed, and what is part of the merge. I wouldn't worry about the amount of commits you have. |
|
I think you accidentally squashed the merge of |
|
Had a super busy week so I didnt have much time to check in but yeah thats my bad, sorry 😓 I wasnt sure of what was the standard procedure for merging, probly should have asked. Thanks for the tips @goldbattle, I'll work on it tomorrow then revert my last commit, make a fresh one with only merge code from master, then another commit with my changes. |
This reverts commit 561bce7.
manually squashing changes
now uses local storage to remember the delay setting on a per channel basis
|
Made some changes based on suggestions from @goldbattle Changed the element that displays the delay setting: It now remembers the setting you selected for a channel. If you havent changed the settings on a particular channel, it will simply use the default delay since as @pencil said the default delay works well in the vast majority of cases. |
Fixed an issue where the delay value loaded from storage was not being properly assigned
This pull request adds some additional ui elements along with the ability to manually adjust the chat delay.
The delay is updated by modifying the existing variable
ReChat.Playback.streamDelaybased on user input.Repurposed the familiar twitch chat room selection button to show/hide the delay adjustment controls. Here is the header with controls toggled off:
toggled on:
The dropdown changes how many seconds the delay is adjusted by on each operation. The left button decreases the delay by the selected amount and the right button increases the delay by the selected amount. The display shows the current delay offset.
Tested in Chrome 45.0.2454.101 m and Firefox 41.0.1
All feedback is appreciated, thanks.