-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatabaseHost alias #403
Conversation
Sorry I don't get what this solves. You should be able to use the domain in the host column and the name is the "alias" |
It's for users that use a local ip or |
We have a 'Display Name' section. The admin could just put |
The Display name is only for the admin side its not passed to react and never was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like Charles said the Display Name
is supposed to be used as an alias.
Could change the PR to fix that? Thanks.
I thought it was just a name on the admin side kinda like for Nodes |
You can do it now, it's just a small edit. #353 will take a while. |
I was looking for issues to solve on Pterodactyl's git and i stumbled upon this one that made me unsure about the solution, should i follow what was previously said or implement it differently to comply with that issue aswell ? Maybe make alias an array (would make jdbc harder but tbh you won't use jdbc connection string outside of your server so we can set it to the first alias) |
After reading the original issue, I think it has some merit, however I think we should think more carefully about the execution. Let's continue this in a repo discussion! |
Add alias to DatabaseHosts and display that instead of the ip in the endpoint.
Useful when you create [email protected] but still want to show either a domain or for example 172.18.0.1