Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatabaseHost alias #403

Closed

Conversation

RMartinOscar
Copy link
Contributor

Add alias to DatabaseHosts and display that instead of the ip in the endpoint.
Useful when you create [email protected] but still want to show either a domain or for example 172.18.0.1
List
Edit
Create
Client side eye
Client side list

@lancepioch
Copy link
Member

Sorry I don't get what this solves. You should be able to use the domain in the host column and the name is the "alias"

@Boy132
Copy link
Member

Boy132 commented Jun 16, 2024

Sorry I don't get what this solves. You should be able to use the domain in the host column and the name is the "alias"

It's for users that use a local ip or localhost for the host but want to show a different value.

@notAreYouScared
Copy link
Member

Sorry I don't get what this solves. You should be able to use the domain in the host column and the name is the "alias"

It's for users that use a local ip or localhost for the host but want to show a different value.

We have a 'Display Name' section. The admin could just put db.pelican.dev and that would be displayed to the end-user on the connection details. Unless that's broken?

@RMartinOscar
Copy link
Contributor Author

We have a 'Display Name' section. The admin could just put db.pelican.dev and that would be displayed to the end-user on the connection details. Unless that's broken?

The Display name is only for the admin side its not passed to react and never was

Copy link
Member

@Boy132 Boy132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Charles said the Display Name is supposed to be used as an alias.
Could change the PR to fix that? Thanks.

@RMartinOscar
Copy link
Contributor Author

RMartinOscar commented Jun 17, 2024

Like Charles said the Display Name is supposed to be used as an alias. Could change the PR to fix that? Thanks.

I thought it was just a name on the admin side kinda like for Nodes
That means i'd have to edit the old client part is it worth doing or should i wait and reimplement it after #353 ?

@RMartinOscar RMartinOscar marked this pull request as draft June 17, 2024 06:46
@Boy132
Copy link
Member

Boy132 commented Jun 17, 2024

Like Charles said the Display Name is supposed to be used as an alias. Could change the PR to fix that? Thanks.

I thought it was just a name on the admin side kinda like for Nodes That means i'd have to edit the old client part is it worth doing or should i wait and reimplement it after #353 ?

You can do it now, it's just a small edit. #353 will take a while.

@RMartinOscar
Copy link
Contributor Author

RMartinOscar commented Jul 1, 2024

I was looking for issues to solve on Pterodactyl's git and i stumbled upon this one that made me unsure about the solution, should i follow what was previously said or implement it differently to comply with that issue aswell ?

Maybe make alias an array (would make jdbc harder but tbh you won't use jdbc connection string outside of your server so we can set it to the first alias)

@RMartinOscar RMartinOscar requested a review from Boy132 July 1, 2024 04:52
@lancepioch
Copy link
Member

After reading the original issue, I think it has some merit, however I think we should think more carefully about the execution. Let's continue this in a repo discussion!

@lancepioch lancepioch closed this Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants