Added footer & small improvments #246
Conversation
Co-authored-by: Lance Pioch <[email protected]>
Right now i have the Return to Client on the nav bar like this:
If you like that more i can also add it to the user menu like this:
Which ever one you like more |
|
2nd one is nice. Return to Client on top |
|
So the footer looks nice but also awkward because it's abruptly cut off. |
Yes that is because I set it to the footer of het navbar, but with my last commit I changed it to look like this:
But if i do that it is constantly in view like this: So what if i do it like this:
Only i have not found a fix for it not being visible if topbar is enabled. Will work on that |
|
We can use this one. |
|
Very last screenshot looks good, think we can get that one in |
Oké well that is the one I have for this PR right now so I think the PR can be merged then. |
| <style> | ||
| footer { | ||
| padding: 0; | ||
| margin: 0; | ||
| height: auto; | ||
| background: none; | ||
| bottom: 8px; | ||
| } | ||
|
|
||
| footer .flex { | ||
| padding: 0.25rem 0; | ||
| margin: 0; | ||
| } | ||
|
|
||
| footer img { | ||
| margin-right: 8px; | ||
| } | ||
|
|
||
| footer span { | ||
| padding: 0; | ||
| margin: 0; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
These should just be tailwind classes above
There was a problem hiding this comment.
The styles defined in the <style> block should remain because changing them to Tailwind classes alone does not work then the footer is over Pelican for some reason. I have not got it working in any other way except this one.
| @@ -50,6 +51,14 @@ public function panel(Panel $panel): Panel | |||
| 'warning' => Color::Amber, | |||
| 'blurple' => Color::hex('#5865F2'), | |||
| ]) | |||
| ->renderHook('panels::sidebar.footer', fn () => view('filament.footer')) // TODO make the footer also work with topNavigation | |||
There was a problem hiding this comment.
| ->renderHook('panels::sidebar.footer', fn () => view('filament.footer')) // TODO make the footer also work with topNavigation | |
| ->renderHook(PanelsRenderHook::FOOTER, fn () => view('filament.footer')) // TODO make the footer also work with topNavigation |
There was a problem hiding this comment.
When you do this with only footer and not sidebar footer then you have this:
I have tested almost all of the renderhooks and this is the only one that comes out nice:
|
For better or worse I think it'll be best for us to absolutely stick with TailwindCSS instead of using raw CSS in here. Let's try to tackle that. |
Oke i cant get it to work with Tailwind so if one of the team members can try that. That would be great |
|
Let's table this for now until we can figure out Tailwind. It will probably be a lot easier after #353 |
No description provided.