added a straight rain option #9
Conversation
|
@ajohnson1031 Thanks for your contribution and interest in this project. I'd like to support the straight-down animations that you requested. Adding an additional, near-identical version of the component makes it difficult to maintain. Fixes in one module would need to be carried over to the other. Would you investigate the spring and swingArc methods when the velocity is 0? It could be a matter of short-circuiting the return in the spring if the velocity is 0. The swingArc method may need the velocity parameter to do the same. |
|
I'll definitely look into it. Having a bit of trouble getting the example
off the ground, so can't test locally just yet.
…On Fri, May 28, 2021 at 11:58 AM Peace ***@***.***> wrote:
@ajohnson1031 <https://github.com/ajohnson1031> Thanks for your
contribution and interest in this project.
I'd like to support the straight-down animations that you requested.
Adding an additional, near-identical version of the component makes it
difficult to maintain. Fixes in one module would need to be carried over to
the other.
Would you investigate the spring and swingArc methods when the velocity is
0?
https://github.com/peacechen/react-native-make-it-rain/blob/0ec65022db0492c504726d8f1b1661360baa7cdf/src/makeItRain.js#L85
It could be a matter of short-circuiting the return in the spring if the
velocity is 0. The swingArc method may need the velocity parameter to do
the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4KMTYHERNDUKZIUW5CEWLTP64RBANCNFSM45W3AJ2A>
.
|
|
If you have an app already set up, you could edit the source files under |
|
True. I'll try that in a bit. I'd like to try tackling the excessive
promises issue as well, since it's breaking my app. Could you point me in
the right direction?
…On Fri, May 28, 2021 at 1:59 PM Peace ***@***.***> wrote:
If you have an app already set up, you could edit the source files under
node_modules/react-native-make-it-rain. You'll then need to copy those
over to your fork in order to submit them in a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4KMT5YWKOW45JZSYXHHEDTP7KZBANCNFSM45W3AJ2A>
.
|
|
The recommendation by the reanimated team is to migrate to reanimated v2. However, another thread says that v2 has poor performance. Someone made an unmounting patch but I'm not sure whether it made it into the library. |
Let me know if this is okay with you.