Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #8

Merged
merged 3 commits into from
May 19, 2024
Merged

Minor improvements #8

merged 3 commits into from
May 19, 2024

Commits on May 19, 2024

  1. Write finished groups without loop 

    io.Writer.Write requires an error to be returned if a partial write
was done.
No need for a loop when writing a finished group.

Signed-off-by: Pieter De Gendt <[email protected]>
    @pdgendt
    pdgendt committed May 19, 2024
    Configuration menu
    Copy the full SHA
    eb6ddb5 View commit details
    Browse the repository at this point in the history

  2. Change occurrences of "block" to "group" 

    Keep naming consistent.

Signed-off-by: Pieter De Gendt <[email protected]>
    @pdgendt
    pdgendt committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f21f46b View commit details
    Browse the repository at this point in the history

  3. Consistent result types/names 

    One function had named return values, keep is consistent with other
functions.

Signed-off-by: Pieter De Gendt <[email protected]>
    @pdgendt
    pdgendt committed May 19, 2024
    Configuration menu
    Copy the full SHA
    824c5b2 View commit details
    Browse the repository at this point in the history