fix(transform): Add support for ancient ZFS dedupratio metric

Fixes #26
pdf · Jan 28, 2023 · 85bdc3b · 85bdc3b
1 parent 4e44fdf
commit 85bdc3b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/collector/pool_test.go b/collector/pool_test.go
@@ -167,18 +167,22 @@ zfs_pool_unsupported{pool="testpool"} 1024
 `,
 		},
 		{
-			name:           `legacy fragmentation`,
+			name:           `legacy fragmentation/dedupratio`,
 			pools:          []string{`testpool`},
-			propsRequested: []string{`fragmentation`},
-			metricNames:    []string{`zfs_pool_fragmentation_ratio`},
+			propsRequested: []string{`fragmentation`, `dedupratio`},
+			metricNames:    []string{`zfs_pool_fragmentation_ratio`, `zfs_pool_deduplication_ratio`},
 			propsResults: map[string]map[string]string{
 				`testpool`: {
 					`fragmentation`: `5%`,
+					`dedupratio`:    `2.50x`,
 				},
 			},
 			metricResults: `# HELP zfs_pool_fragmentation_ratio The fragmentation ratio of the pool.
 # TYPE zfs_pool_fragmentation_ratio gauge
 zfs_pool_fragmentation_ratio{pool="testpool"} 0.05
+# HELP zfs_pool_deduplication_ratio The ratio of deduplicated size vs undeduplicated size for data in this pool.
+# TYPE zfs_pool_deduplication_ratio gauge
+zfs_pool_deduplication_ratio{pool="testpool"} 0.4
 `,
 		},
 	}

diff --git a/collector/transform.go b/collector/transform.go
@@ -74,6 +74,9 @@ func transformPercentage(value string) (float64, error) {
 }
 
 func transformMultiplier(value string) (float64, error) {
+	if len(value) > 0 && value[len(value)-1] == 'x' {
+		value = value[:len(value)-1]
+	}
 	v, err := transformNumeric(value)
 	if err != nil {
 		return -1, err