Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking Ry encoder (SSI protocol) and CoE settings #73

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

jyotiphy
Copy link
Contributor

Description

Replaced rotation Y (Ry) stage and encoder. This encoder is unsupported (SSI protocol) but seem to work with EL5042 after some troubleshooting. Linking Encoder and some CoE settings.

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-1321

How Has This Been Tested?

yes, tested and seems to be working

Where Has This Been Documented?

No

Pre-merge checklist

  • [x ] Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • [ x] Libraries are set to fixed versions and not Always Newest
  • [ x] Code committed with pre-commit (alternatively pre-commit run --all-files)

@jyotiphy jyotiphy requested a review from NSLentz March 25, 2024 20:44
NSLentz
NSLentz previously approved these changes Mar 25, 2024
Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jyotiphy jyotiphy requested a review from NSLentz March 26, 2024 18:19
Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jyotiphy jyotiphy merged commit 6d5abd4 into pcdshub:master Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants