Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spec recommended additional fee API #86

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Support spec recommended additional fee API #86

merged 5 commits into from
Aug 8, 2023

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Jul 14, 2023 •
edited
Loading

Support spec recommended additional fee API and support it in payjoin-cli

  1. The first commit only calculates additional fee parameters in payjoin-cli without API change, but this PR should change the API to facilitate that part of the protocol.
  2. The second commit uses bitcoin::FeeRate in Configuration
  3. The third constructs a recommended Configuration by finding the additionalfeenoutputindex, specifying maxadditionalfeecontribution and minfeerate assuming funds are available
  4. The fourth fixes a bug and allows decimal minfeerate parameter as specified in BIP 78
  5. automatically detect script type if there is a recommendation we can identify

close #71

@DanGould DanGould added this to the 0.10.0 milestone Jul 31, 2023
@DanGould DanGould self-assigned this Jul 31, 2023
@DanGould DanGould force-pushed the rec-fee branch 3 times, most recently from 354f122 to 51298c9 Compare August 1, 2023 20:03
@DanGould DanGould marked this pull request as ready for review August 1, 2023 20:03
@DanGould DanGould force-pushed the rec-fee branch 5 times, most recently from bf6a912 to 54f8c83 Compare August 2, 2023 00:00
DanGould
DanGould commented Aug 3, 2023
View reviewed changes
payjoin-cli/src/app.rs Outdated Show resolved Hide resolved
payjoin-cli/src/app.rs Show resolved Hide resolved
payjoin-cli/src/app.rs Show resolved Hide resolved
payjoin/src/receive/optional_parameters.rs Outdated Show resolved Hide resolved
payjoin/src/send/mod.rs Outdated Show resolved Hide resolved
@DanGould DanGould force-pushed the rec-fee branch 3 times, most recently from 819b6a1 to e7db425 Compare August 3, 2023 17:35
@DanGould DanGould merged commit 9588dc2 into payjoin:master Aug 8, 2023
7 checks passed
@DanGould DanGould mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DanGould DanGould

Labels
api payjoin-cli send sending payjoin
Projects
Payjoin Roadmap 📝
Archived in project
Milestone
0.10.x- Initial Production
Development

Successfully merging this pull request may close these issues.

Configuration should support spec recommended additional fee
1 participant
@DanGould