curious if it's possible to run matoya tests in CI #115
+129
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curious if it's possible to run matoya tests in CI
bmcnett
added
the
1. Coding
windows won't even nmake yet
this test may have not been working for a few years, now
… valid condition) this test shouldn't fail if sleep took longer than expected (that's a valid condition)
just a random guess for why this is failing for linux / mac
…n error until i can figure out why it's failing, i can have it fail without an error
derpity derp
more derping
on push or label-add, it tests if 'Test Matoya' flag is set
bmcnett
added
Test Matoya
wonder if this works
need steps, apparently
…s for no good reason these tests seem to hit rate limiters on a website, and fail sometimes for no good reason
printing messages in github's preferred format
tests are now deterministic (except those for MTY_*Random*)
let's use a format github likes
a little simpler
added a test that fails if the recent JSON fix is absent
can this be removed?
can this be removed, too?
environment variable "seed" should be "MATOYA_TEST_SEED"
bmcnett
added
the
2. Review requested
|
Doesn't look like tests are running, are they supposed to before we can review? |
|
This work should IMHO be delayed until our matoya fork is merged into the Parsec repo. At that point, setting up MTY tests to run in CI should be immune to these weird CI oddities that Julien might be hinting at. Moved label to L1 in light of this, but if you disagree, feel free to respond and bring the label back to L2. |
dvijayak
added
1. Coding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curious if it's possible to run matoya tests in CI