Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Flutter 3.13, 3.16, 3.19; remove support for Flutter 3.3, 3.7 #994

Merged

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Closes: #992

Approach

n/a

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii requested a review from mtrezza April 2, 2024 07:03
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (c388545) to head (566bf03).
Report is 3 commits behind head on master.

❗ Current head 566bf03 differs from pull request most recent head f0d46f2. Consider uploading reports for the commit f0d46f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   43.37%   43.43%   +0.05%     
==========================================
  Files          61       61              
  Lines        3463     3463              
==========================================
+ Hits         1502     1504       +2     
+ Misses       1961     1959       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested review from mtrezza and removed request for mtrezza April 7, 2024 18:17
@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Apr 7, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change since we are removing support for older flutter versions, right? Could you please rename the PR title to

feat: Add support for Flutter x.x, x.x; remove support for Flutter x.x, x.x


dependencies:
flutter:
sdk: flutter

parse_server_sdk: ^5.1.3
parse_server_sdk: ^6.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge #993 first and then set this to ^7.0.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ,this is a better method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can upgrade now and then let's see if the CI passes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the conflicts in flutter 3.10 with parse_server_sdk 7.0.0, it is not possible to upgrade parse_server_sdk until Flutter 3.10 is supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the procedure to go forward?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait until July 2024 to upgrade.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will cause any problem and you can merge this PR

@mbfakourii mbfakourii changed the title docs: Compatibility update in Flutter feat: Add support for Flutter 3.13, 3.16, 3.19; remove support for Flutter 3.3, 3.7 Apr 8, 2024
@mbfakourii
Copy link
Member Author

This is a breaking change since we are removing support for older flutter versions, right? Could you please rename the PR title to

feat: Add support for Flutter x.x, x.x; remove support for Flutter x.x, x.x

Yes, the title has also changed.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry and bump the SDK version?

@mbfakourii
Copy link
Member Author

Could you add a changelog entry and bump the SDK version?

Added.

@mbfakourii
Copy link
Member Author

@mtrezza

You may check this PR.

@mtrezza mtrezza merged commit 3274981 into parse-community:master May 15, 2024
5 of 8 checks passed
@mbfakourii mbfakourii deleted the compatibility-update-in-flutter branch August 27, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package connectivity_plus is old
2 participants