Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of is_unreachable #3023

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 22, 2022

Close #1531
cc #2746

This PR renames is_unreachable to is_bad_address.
It is generally not possible to know whether an address is definitely unreachable or not. The only situation where we can affirm that an address is definitely unreachable is if our implementation doesn't support a certain protocol that it uses.

This matches what the browser node already does anyway.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka
Copy link
Contributor Author

tomaka commented Nov 22, 2022

For what it's worth, I don't really like the API of pending_outcome_err as it is a bit too vague/magic. This is covered by #2746

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Nov 23, 2022
@mergify mergify bot merged commit 9428780 into paritytech:main Nov 23, 2022
@tomaka tomaka deleted the clarify-is-unreachable branch November 23, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm node passes wrong value for reachability in pending_outcome_err
1 participant