Clarify meaning of is_unreachable #3023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1531
cc #2746
This PR renames
is_unreachable
tois_bad_address
.It is generally not possible to know whether an address is definitely unreachable or not. The only situation where we can affirm that an address is definitely unreachable is if our implementation doesn't support a certain protocol that it uses.
This matches what the browser node already does anyway.