Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add OpenGov to Rococo and Westend runtimes #7272

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented May 23, 2023

As per this comment, the changes in this MR include the following pallets into [x] Rococo and [x] Westend runtimes:

  • pallet_conviction_voting
  • pallet_referenda
  • pallet_ranked_collective
  • pallet_custom_origins
  • pallet_whitelist

And only for westend-runtime:

  • pallet_treasury

Following Kusama runtime config as a baseline.

Benchmarking of the following pallets done for Rococo and Westend:

  • pallet_conviction_voting
  • pallet_referenda
  • pallet_ranked_collective
  • pallet_whitelist

And only for Westend:

@al3mart al3mart added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 23, 2023
@al3mart al3mart requested a review from riusricardo May 23, 2023 11:12
@al3mart al3mart added the A0-please_review Pull request needs code review. label May 23, 2023
@al3mart al3mart changed the title Set bounties SpendOrigin in Rococo to EnsureRoot Set treasury SpendOrigin in Rococo to EnsureRoot May 23, 2023
@al3mart al3mart marked this pull request as draft May 23, 2023 11:31
@al3mart
Copy link
Contributor Author

al3mart commented May 23, 2023

Seems that I went to fast with the changes, will convert to draft for the moment until all commits are in place.

@al3mart al3mart changed the title Set treasury SpendOrigin in Rococo to EnsureRoot Allow Root as SpendOrigin in Rococo May 23, 2023
@al3mart
Copy link
Contributor Author

al3mart commented May 23, 2023

Might as well transform this MR into introducing OpenGov in Rococo as there as been some interest.

@al3mart al3mart removed the A0-please_review Pull request needs code review. label May 24, 2023
@al3mart al3mart changed the title Allow Root as SpendOrigin in Rococo Add OpenGov to Rococo and Westend runtimes Jul 5, 2023
@al3mart al3mart marked this pull request as ready for review July 6, 2023 15:57
@al3mart
Copy link
Contributor Author

al3mart commented Jul 6, 2023

I might do a few more commits removing Gov1 from Rococo, but opening for reviews to see if anything needs addressing with the inclusion of the pallets mentioned in the description.

@al3mart al3mart requested a review from muharem July 6, 2023 16:00
// --execution=wasm
// --wasm-execution=compiled
// --header=./file_header.txt
// --output=./runtime/kusama/src/weights/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it just copied from kusama? is it ok or ideally it should be generated with command bot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd say that generating its own weights would be the way to go. I'll address this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you rerun them? this file would be rewritten

runtime/rococo/src/governance/fellowship.rs Outdated Show resolved Hide resolved
max_deciding: 10,
decision_deposit: 100 * QUID,
prepare_period: 30 * MINUTES,
decision_period: 7 * DAYS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we want the exact same configs, or we want to relax all constraints, to have shorter periods, approve and support curves, etc

runtime/rococo/src/governance/mod.rs Outdated Show resolved Hide resolved
// --execution=wasm
// --wasm-execution=compiled
// --header=./file_header.txt
// --output=./runtime/kusama/src/weights/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its one way to do this. to copy from other network or even substrate, and after run the weights via PR bot

@al3mart
Copy link
Contributor Author

al3mart commented Aug 5, 2023

@mordamax @muharem @joepetrowski I think we can follow up with the review now :)
Gov1 related stuff has been removed from rococo's runtime.

It might be interesting to get this merge before the migration to the monorepo :P

@al3mart al3mart marked this pull request as ready for review August 5, 2023 00:23
@al3mart al3mart removed the request for review from riusricardo August 5, 2023 00:25
@muharem muharem self-requested a review August 10, 2023 12:12
runtime/rococo/src/governance/fellowship.rs Outdated Show resolved Hide resolved
// --execution=wasm
// --wasm-execution=compiled
// --header=./file_header.txt
// --output=./runtime/kusama/src/weights/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you rerun them? this file would be rewritten

runtime/westend/src/governance/fellowship.rs Outdated Show resolved Hide resolved
@muharem
Copy link
Contributor

muharem commented Aug 10, 2023

almost there (:
the main request is to follow Polkadot setup for Westend
push - "Re-request review" when comments addressed

@al3mart
Copy link
Contributor Author

al3mart commented Aug 16, 2023

bot bench $ runtime rococo pallet_whitelist

@command-bot
Copy link

command-bot bot commented Aug 16, 2023

@al3mart Positional arguments are not supported anymore. I guess you meant bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist, but I could be wrong.
Read docs to find out how to run your command.

@al3mart
Copy link
Contributor Author

al3mart commented Aug 16, 2023

bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist

@command-bot
Copy link

command-bot bot commented Aug 16, 2023

@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-bf78976e-d11c-404e-8f75-28587a10bd6d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 16, 2023

@al3mart Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3404547/artifacts/download.

@al3mart
Copy link
Contributor Author

al3mart commented Aug 25, 2023

bot bench polkadot-pallet --runtime=rococo --pallet=pallet_whitelist

@command-bot
Copy link

command-bot bot commented Aug 25, 2023

@al3mart https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-8307bfdb-702f-46a0-8ce5-cf393f2f861a to cancel this command or bot cancel to cancel all commands in this pull request.

…e=rococo --target_dir=polkadot --pallet=pallet_whitelist
@command-bot
Copy link

command-bot bot commented Aug 25, 2023

@al3mart Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=rococo --target_dir=polkadot --pallet=pallet_whitelist has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3437453/artifacts/download.

@al3mart
Copy link
Contributor Author

al3mart commented Aug 25, 2023

Ready for another review round

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants