Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix parity-publish (#5670) #5907

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

EgorPopelyaev
Copy link
Contributor

Backport of the fix that prevents parity-publish from failing during installation.

EgorPopelyaev and others added 2 commits October 2, 2024 14:25
Install with `--locked` to try to fix the CI.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@EgorPopelyaev EgorPopelyaev added R0-silent Changes should not be mentioned in any release notes A3-backport Pull request is already reviewed well in another branch. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Oct 2, 2024
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners October 2, 2024 12:29
Copy link

github-actions bot commented Oct 2, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Cargo.lock Show resolved Hide resolved
@EgorPopelyaev EgorPopelyaev merged commit 660da7a into stable2409 Oct 2, 2024
210 of 236 checks passed
@EgorPopelyaev EgorPopelyaev deleted the ep-fix-parity-publish branch October 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants