try making bench numbers make sense #5526
Conversation
ordian
added
the
T12-benchmarks
|
bot bench polkadot-pallet --pallet=polkadot_runtime_parachains::inclusion --runtime=westend |
|
/cmd bench --help |
|
/cmd bench --runtime westend rococo --pallet=polkadot_runtime_parachains::inclusion |
…=westend --target_dir=polkadot --pallet=polkadot_runtime_parachains::inclusion
…=rococo --target_dir=polkadot --pallet=polkadot_runtime_parachains::inclusion
|
bot bench polkadot-pallet --pallet=polkadot_runtime_parachains::inclusion --runtime=westend |
…=westend --target_dir=polkadot --pallet=polkadot_runtime_parachains::inclusion
|
bot bench polkadot-pallet --pallet=polkadot_runtime_parachains::inclusion --runtime=westend |
|
/cmd bench --runtime westend rococo --pallet=polkadot_runtime_parachains::inclusion |
|
Command "bench --runtime westend rococo --pallet=polkadot_runtime_parachains::inclusion" has started 🚀 See logs here |
…=westend --target_dir=polkadot --pallet=polkadot_runtime_parachains::inclusion
|
@ordian Command |
|
Command "bench --runtime westend rococo --pallet=polkadot_runtime_parachains::inclusion" has failed ❌! See logs here |
| doc: | ||
| - audience: Runtime Dev | ||
| description: | | ||
| This PR works around an issue in multivariate linear regression of weight generation. |
There was a problem hiding this comment.
Is there an issue for this and shall we reference it from the benchmarks, so the values can be changed back once fixed?
There was a problem hiding this comment.
I'll need to dig a bit deeper to provide meaningful feedback for the issue, but I don't think there's a need to change those values back once fixed. The purpose of linear regression is to find the right correlation and if it can be achieved with just a points, there is no need to add more.
Follow-up to #5270. The baseline numbers for Westend were too high to be representative of the reality as it seemed to do with how multi-variate linear regression is calculated.