pallet-xcm: added useful error logs (#2408) #4982
Conversation
|
@ayevbeosa this is good, but does not yet fix #2408 - this PR only covers |
Thanks @acatangiu, is it okay to do everything in this PR or I should break it in parts? |
|
I think you can do it in same PR since they're not that many changes |
|
Review required! Latest push from author must always be reviewed |
Co-authored-by: Francisco Aguirre <[email protected]>
|
@ayevbeosa do you still plan on getting this over the finish line? |
Sure! Asides resolving the merge conflict, is there anything else left? |
Nope, merge master and have CI passing and we'll merge it. |
github-actions
bot
requested review from
acatangiu,
bkontur and
franciscoaguirre
| @@ -1087,7 +1095,10 @@ impl<Config: config::Config> XcmExecutor<Config> { | |||
| tracing::trace!(target: "xcm::executor::BuyExecution", asset_used_for_fees = ?self.asset_used_for_fees); | |||
| // pay for `weight` using up to `fees` of the holding register. | |||
| let max_fee = | |||
| self.holding.try_take(fees.into()).map_err(|_| XcmError::NotHoldingFees)?; | |||
| self.holding.try_take(fees.clone().into()).map_err(|e| { | |||
| log::error!(target: "xcm::process_instruction::buy_execution", "Failed to take fees {fees:?} from holding with error: {e:?}"); | |||
There was a problem hiding this comment.
@ayevbeosa can you please:
- change all
log::errortotracing::errorformat forxcm-executor - check existing logs, e.g. this one can be extended with more info
tracing::error!(target: "xcm::reanchor", ?error, "Failed reanchoring with error");
Added error logs in pallet-xcm to help in debugging, fixes #2408
TODO
log::errortotracing::errorformat forxcm-executortracing::error!(target: "xcm::reanchor", ?error, "Failed reanchoring with error");