Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar ghosting with valid connection - part 2 #574

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Conversation

zfi
Copy link
Contributor

@zfi zfi commented Apr 16, 2021

This update further addresses issue #572.
Notify clientService when a com port is selected so it can notify the Launcher of the selection.
The setSelectedPort method now sends an update to the Launcher only when the selected com port has changed.
Migrate the hasCode function to the blockly module.

@zfi zfi added bug Something isn't working Beta Issue The issue is reported in a beta release labels Apr 16, 2021
@zfi zfi added this to the Release v1.5.8 milestone Apr 16, 2021
@zfi zfi requested a review from pjewald April 16, 2021 22:44
Copy link
Collaborator

@pjewald pjewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lg2m

@pjewald pjewald merged commit 3aa50d6 into develop Apr 16, 2021
@pjewald pjewald deleted the Issue_572-patch_2 branch April 20, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Issue The issue is reported in a beta release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants