Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): align trace output with geth #195

Closed
wants to merge 1 commit into from
Closed

fix(tracing): align trace output with geth #195

wants to merge 1 commit into from

Conversation

pythonberg1997
Copy link
Contributor

@pythonberg1997 pythonberg1997 commented Sep 12, 2024 •
edited
Loading

  1. The error msg should not be converted to parity style in callTracer. They should only be converted in flatCallTracer which is not supported by reth now.
  2. The gasUsed should be the gasLimit when there's a not reverted error.

Related geth code:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pythonberg1997