Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discv5 support #6151

Closed
wants to merge 211 commits into from
Closed

Discv5 support #6151

wants to merge 211 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 21, 2024 •
edited
Loading

since we import rust discv5 from sigp, this pr modifies the discv4 code. discv4 now drops nodes in Neighbours responses that are already connected in discv5. it verifies this by access to a mirror of keys in discv5's kbuckets, that is updated, if needed, when discv4 receives a Neighbours message. the goal is to ensure any two nodes are connected over discv5 xor discv4, preferring discv5. nodes are identified by their node id, so to make this possible, nodes use the same secret key in discv4 and discv5. closes #1383.

also moves poll function in Discovery impl to Stream impl for Discovery.

@emhane emhane marked this pull request as draft January 21, 2024 18:38
emhane
emhane commented Jan 25, 2024
View reviewed changes
crates/net/discv5/src/lib.rs Outdated Show resolved Hide resolved
emhane and others added 20 commits March 26, 2024 14:56
@emhane
Fix naming
ecaece6
@emhane
Disable same filter used during lookup queries as on result passed to…
bee9d62 
… mempool
@emhane
Temp hardcode filter to exlcude eth2 nodes
d55fda2
@emhane
fixup! Fix network args and make config in manager
3ceb8e3
@emhane
fix lint
440db80
@emhane
Use discv5 default port and set tcp port
9930360
@emhane
Temp use other ports to allow testing
989c129
@emhane
fixup! Temp use other ports to allow testing
9bc1c2b
@emhane
fixup! Temp use other ports to allow testing
12e29a5
@emhane
fixup! Temp use other ports to allow testing
fe45c19
@emhane
Temp disable discv4 for p2p command test
b68b3f6
@emhane
Add sepolia bootstrap nodes
b32df13
@emhane
Bump zstd
3d49986
@emhane
Remove use of local method
5c11bdc
@emhane
Show disconnected bootnodes
a97b0ba
@emhane
Use op mainnet bootstrap nodes for base mainnet
e644ea2
@emhane
Use op sepolia bootnodes for base sepolia
b558124
@joshieDo
add recover_signer_unchecked_with_buffer to TransactionSignedNoHash
c628cc4
@joshieDo
clippy
409c5eb
@joshieDo
clear buffer before use
211da78
@emhane emhane mentioned this pull request Mar 28, 2024
Merged
@emhane emhane mentioned this pull request Mar 30, 2024
Closed
@emhane
Copy link
Member Author

emhane commented Apr 4, 2024

decomposed into #7446, #7394 and #7328

@emhane emhane closed this Apr 4, 2024
@emhane emhane deleted the emhane/discv5-support branch April 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected left review comments

@mattsse mattsse mattsse requested changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Evalir Evalir Awaiting requested review from Evalir

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita

Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol A-discv5 Related to discv5 discovery A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

discv5 support
4 participants
@emhane @joshieDo @Rjected @mattsse