chore(rpc): improve debug_traceBlock performance #11069
Open
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First approach done, ready for review & feedback |
mattsse
reviewed
Sep 21, 2024
| @@ -332,7 +341,7 @@ where | |||
| Ok(frame.into()) | |||
| }) | |||
| .await?; | |||
| return Ok(frame) | |||
| return Ok(frame); | |||
There was a problem hiding this comment.
could you please undo these, makes it harder to review, idk why they keep reappearing...
There was a problem hiding this comment.
when you run cargo fmt and not cargo +nightly fmt...doom
There was a problem hiding this comment.
Oopsie, will update them
There was a problem hiding this comment.
About the approach does modifying the trace_transaction function to accept an optional inspector and return it along with the result and then modify trace_block function to use it sound good?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #11066