Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move eip7002 impl #10998

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: move eip7002 impl #10998

merged 1 commit into from
Sep 18, 2024
+146 −133

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 18, 2024 •
edited
Loading

towards #10955

@onbjerg
Copy link
Member

onbjerg commented Sep 18, 2024

Is this in reference to an issue? If so please add it to the PR description so it autocloses 😊

onbjerg
onbjerg approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm impl wise

mattsse
mattsse approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ser, way cleaner

cc @klkvr sorry these likely have introduced a few conflicts on your wip

@onbjerg onbjerg added the C-debt Refactor of code section that is hard to understand or maintain label Sep 18, 2024
@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
Merged via the queue into paradigmxyz:main with commit 6fc2a23 Sep 18, 2024
36 checks passed
@nkysg nkysg deleted the move_eip7002_impl branch September 18, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkysg @onbjerg @mattsse