Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POCS wait status #1268

Merged
merged 1 commit into from
May 14, 2024
Merged

POCS wait status #1268

merged 1 commit into from
May 14, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 14, 2024

  • The pocs.wait method calls status so there are updates.
  • Slightly longer wait delay if we know it is not dark. This could be improved.

* The `pocs.wait` method calls `status` so there are updates.
* Slightly longer wait delay if we know it is not dark. This could be improved.
@wtgee wtgee self-assigned this May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.40%. Comparing base (68719cf) to head (e9db4e9).

Files Patch % Lines
src/panoptes/pocs/state/states/default/ready.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1268   +/-   ##
========================================
  Coverage    70.40%   70.40%           
========================================
  Files          100      100           
  Lines         8419     8423    +4     
  Branches      1169     1170    +1     
========================================
+ Hits          5927     5930    +3     
- Misses        2342     2343    +1     
  Partials       150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit c0e6750 into develop May 14, 2024
7 checks passed
@wtgee wtgee deleted the pocs-wait-status branch May 14, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant