chore: update validator nonces in endblocker #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way it was before, we would need a claim to be observed so validators would be updated. By doing it in the endblocker, we validators are always up-to-date. This should prevent a situation where the last claim is 19, the last observed nonce is 18, but validators are stuck on nonce 17. They would receive a list of block events with the block of nonce 19 (latest unobserved) but would be unable to claim it, since skyway would expect them to submit a claim for nonce 18 instead.
byte-bandit
reviewed
Sep 13, 2024
byte-bandit
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
The way it was before, we would need a claim to be observed so validators would be updated. By doing it in the endblocker, we validators are always up-to-date.
This should prevent a situation where the last claim is 19, the last observed nonce is 18, but validators are stuck on nonce 17. They would receive a list of block events with the block of nonce 19 (latest unobserved) but would be unable to claim it, since skyway would expect them to submit a claim for nonce 18 instead.
Testing completed
Breaking changes