feat: add webhook helpers #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palexster
force-pushed
the
apa/backport-1
branch
from
e5897a8
to
ba64a78
Compare
palexster
force-pushed
the
apa/backport-1
branch
from
ba64a78
to
e2c8854
Compare
mhrabovcin
reviewed
Nov 13, 2023
| @@ -0,0 +1,7 @@ | |||
| package config | |||
|
|
|||
| type HookType string | |||
There was a problem hiding this comment.
Explain the concept of the hook types, why there is only 1 external.
mhrabovcin
reviewed
Nov 13, 2023
| URL string `json:"url"` | ||
| InsecureSkipVerify bool `json:"insecureSkipVerify"` | ||
| TLSRootCAFile string `json:"tlsRootCAFile"` | ||
| ClientAuthentication *ClientAuthentication `json:"clientAuthentication"` |
There was a problem hiding this comment.
How does the web hook behaves if there is client authentication + insecure skip verify.
mhrabovcin
reviewed
Nov 13, 2023
| @@ -0,0 +1,23 @@ | |||
| package config | |||
|
|
|||
| type ClaimsMutatingHook struct { | |||
mhrabovcin
reviewed
Nov 13, 2023
| Config *WebhookConfig | ||
| } | ||
|
|
||
| type ClaimsValidatingHook struct { |
mhrabovcin
reviewed
Nov 13, 2023
| @@ -0,0 +1,24 @@ | |||
| package config | |||
|
|
|||
| // HookRequestScope is the context of the request | |||
There was a problem hiding this comment.
Can you explain here what it means, of what request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Special notes for your reviewer
Does this PR introduce a user-facing change?