Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rate limits handling to retry user email search #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harryabbott
Copy link

@harryabbott harryabbott commented Feb 9, 2024

as title.
running into rate limit issues when getting hundreds of users userIDs from their email during TF plans. please feel free to change/fix as you see fit.

@der-eismann
Copy link

@pablovarela is this project dead or could you see yourself merging this in the near future? Would be very important for us to have.

@smoya
Copy link

smoya commented May 28, 2024

@pablovarela is this project dead or could you see yourself merging this in the near future? Would be very important for us to have.

Rate limits are a general thing. For example, I'm being hit by it when creating/updating user groups. There was a fix in a PR, but got stale... #72

@ElliotG
Copy link

ElliotG commented Jun 19, 2024

@smoya / @der-eismann --> I've forked the repo for now, and I just pushed v1.2.3 that addresses rate limiting for user groups. I used a slightly different pattern than in this PR, but if @harryabbott is interested, submit a PR there, i'll merge and cut v1.2.4.

https://registry.terraform.io/providers/ElliotG/slack/latest

And for Pablo, i'm happy to merge this back into your code base if you end up picking up this project again.

Copy link

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@smoya
Copy link

smoya commented Sep 18, 2024

ping @pablovarela ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants