Upgrade async library due to CVE-2021-43138 #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1-43138/ There is a security advisory to avoid using async 2.6.3 and below, see https://avd.aquasec.com/nvd/2021/cve-2021-43138/ ``` +------------------+------------------+----------+-------------------+---------------+---------------------------------------+ | LIBRARY | VULNERABILITY ID | SEVERITY | INSTALLED VERSION | FIXED VERSION | TITLE | +------------------+------------------+----------+-------------------+---------------+---------------------------------------+ | async | CVE-2021-43138 | HIGH | 2.6.3 | 2.6.4, 3.2.2 | Prototype Pollution in async | | | | | | | -->avd.aquasec.com/nvd/cve-2021-43138 | +------------------+------------------+----------+-------------------+---------------+---------------------------------------+ ```
|
The logs for the build are no longer available but the build with this bump passes locally |
danyalaytekin
added
the
version: 3
|
Thanks @nicodemuz for your vigilance and @7Ds7 for the test! This or a more recent version will be included in |
danyalaytekin
removed
the
version: 3
danyalaytekin
added a commit
that referenced
this pull request
Nov 10, 2023
Co-Authored-By: nicodemuz <[email protected]>
|
Thanks again for this. Added as a co-authored commit to: |
danyalaytekin
added a commit
that referenced
this pull request
Nov 14, 2023
* Add publishing workflow * Trigger on push to `main` instead of `master` * Test for all pull request targets * Always run linter * Fix node-version variable name * Require `pa11y-lint-config@^3.0.0` * Fix outdated GitHub repo names * Limit Ubuntu support to `20.04` for `pa11y-ci@3` * Add a note for the Pa11y CI issue in Ubuntu * Remove broken dependencies badge * Remove table of contents since GitHub attempts to provide one * Clarify Node support for `pa11y-ci@3` as `12`, `14`, `16` * Provide an example for `--config`, other tweaks * Revise sitemaps, reporters, contributing * Apply new support policy and update table * Upgrade `pa11y` to `^6.2.3` from `~6.1`, following on from #179 Co-Authored-By: Aaron Goldenthal <[email protected]> * Update `async` to `~2.6.4` as shown in #185 ; lockfile was already there Co-Authored-By: nicodemuz <[email protected]> * Switch publisher back to `ubuntu-20.04` * Replace Travis badge with GitHub Actions badge * Update `.editorconfig` to match other Pa11y repos * Set `package.engines.node` to warn outside Node 12-16 * Add `.nvmrc` and set to `14` (12 doesn't run well on Apple Silicon) * Fix `lockfile-version` as `3`, upgrade lockfile from `1` to `3` * Fix Markdown issues and gremlins * Remove unused link definitions * Use more detail to describe Ubuntu issue affecting Pa11y CI 3 * Revert "Fix `lockfile-version` as `3`, upgrade lockfile from `1` to `3`" This reverts commit b9f1af2. * Fix `lockfile-version` to `2`, retaining compatibility with npm 6 (Node 12's bundled npm) * Move glob readme URL into footnotes * Tie together the two lines describing the `object` form of the URL * Fix link definition for `ubuntu-fix` * Add Node versions `18` and `20` to test matrix * Return `engines.node` to `>= 12`, but emphasis the Ubuntu caveat * Update the documented output of `pa11y-ci --help` to match its current form * Remove double-mention of npm commands * Settle on lower-case for OS names * Unquote simple strings * Move linting into its own job * Allow `fail-fast` now that tests are stabilising and linting is separated * Add placeholder to changelog for `3.1` * Fix list indentation in contributing guide * Improve run names inside `test` * Double integration test timeout to preempt locally observed flake * Remove Markdown note now that the Ubuntu note has its own section * Garden the readme * Replace v3 asterisk with named 'Ubuntu caveat' * Revert "Allow `fail-fast` now that tests are stabilising and linting is separated" This reverts commit bd5a094. --------- Co-authored-by: Aaron Goldenthal <[email protected]> Co-authored-by: nicodemuz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a security advisory to avoid using async 2.6.3 and below, see https://avd.aquasec.com/nvd/2021/cve-2021-43138/