Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating _pchecker_summary.txt file during PCheck #740

Merged
merged 1 commit into from
May 29, 2024
Merged

Creating _pchecker_summary.txt file during PCheck #740

merged 1 commit into from
May 29, 2024

Conversation

ChristineZh0u
Copy link
Contributor

@ChristineZh0u ChristineZh0u commented May 28, 2024 •
edited
Loading

  1. Creating _pchecker_summary.txt file during PCheck

@ChristineZh0u ChristineZh0u changed the title Creating pint.txt file during PCheck Creating .pchecker.summary.txt file during PCheck May 28, 2024
@ChristineZh0u ChristineZh0u force-pushed the master branch 2 times, most recently from 4f48f5e to 1e9fd75 Compare May 28, 2024 21:46
@ChristineZh0u ChristineZh0u changed the title Creating .pchecker.summary.txt file during PCheck Creating _pchecker_summary.txt file during PCheck May 28, 2024
@ankushdesai ankushdesai merged commit 610b503 into p-org:master May 29, 2024
6 of 7 checks passed
@aman-goel
Copy link
Contributor

aman-goel commented May 29, 2024 •
edited
Loading

@ChristineZh0u In your next PR, may I ask to also include a field called memory_max_mb: when printing the summary file here. The max memory usage in mega bytes is available from the Profiler class through GetMaxMemoryUsage() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushdesai ankushdesai ankushdesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineZh0u @aman-goel @ankushdesai