feat: Implement "scroll-back" to latest message when navigating replies #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a navigation history for quoted messages, such as if Alice navigated to message A by pressing the "quoted message" inside the reply message B and pressed the "scroll down button", the chat will be scrolled back to message B instead of the very bottom. This is true for as many replies as the user navigates through. All the messages higher than the lowest fully visible message are automatically cleared from the stack as the user scrolls. This feature makes it easier to read threaded conversations, especially in scenarios with much to catch up on. This is most useful in group chats and communities.
f-person
commented
Jul 28, 2023
| } | ||
|
|
||
| func onScrollFinished() { | ||
| DispatchQueue.main.async { [weak self] in |
There was a problem hiding this comment.
Do we perhaps want to add the older code from scrollViewDidEndDragging and scrollViewDidEndScrollingAnimation to onScrollFinished as well? I'm not entirely sure they need to be fired every time scrolling is complete, though :)
| // MARK: - SessionUtilRespondingViewController | ||
|
|
||
| func isConversation(in threadIds: [String]) -> Bool { | ||
| return threadIds.contains(self.viewModel.threadData.threadId) | ||
| } | ||
| } | ||
|
|
||
| struct ConversationReplyNavigationStack { |
There was a problem hiding this comment.
I couldn't find a better place to add this, but let me know if there is one, and I'll move it :)
|
@RyanRory PTL :) |
|
I'll add this to the planning backlog, but will require some review and will be fairly low priority for now considering other tasks ongoing (Push notification and disappearing message overhauls) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This commit adds a navigation history for quoted messages, such as if
Alice navigated to message A by pressing the "quoted message" inside the
reply message B and pressed the "scroll down button", the chat will be
scrolled back to message B instead of the very bottom. This is true for
as many replies as the user navigates through.
All the messages higher than the lowest fully visible message
are automatically cleared from the stack as the user scrolls.
This feature makes it easier to read threaded conversations,
especially in scenarios with much to catch up on. This is most useful in
group chats and communities.
Demo screen recording:
Screen.Recording.2023-07-28.at.21.14.03.mov