forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed group chunk3 #3052
Open
Bilb
wants to merge
154
commits into
oxen-io:unstable
Choose a base branch
from
Bilb:closed-group-chunk3
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Closed group chunk3 #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the signature work with the admin key, fetching it from the usergroups wrapper
still a wip though
this is because we need to be able to override what is returned by what is in the redux lib slice if needed (libsession data overrides what is in the DB for groupv3)
until we get the groupinfo name from polling
before testing
because we still need to process some things even if he is blocked (getting promoted, etc). If the message needs to be dropped, we should not have that group at all, so that message will be dropped nevertheless
this is just another reason to get rid of the duplication between the DB and libsession. We should be able to trust what we get from libsession, but currently we have to trust that we update the DB with what we get from libsession.
Bilb
force-pushed
the
closed-group-chunk3
branch
from
June 11, 2024 23:40
87d5226
to
9b124d3
Compare
also delete all messages when reinvited to a group we were kicked from
Bilb
force-pushed
the
unstable
branch
2 times, most recently
from
August 13, 2024 03:52
d156756
to
03df7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.