Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Restructure e2e tests data storage for keycloak #10895

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented May 13, 2024

Description

There is a requirement of ocis user attributes like UUID whenever the user has some activity using API. So currently, in order to get the UUID, there is everytime login through UI and get the UUID. To prevent this long process time consuming of getting the user's UUID, the UUID is stored.
The user attributes of keycloak is now map and stored in new variable keycloakCreatedUser

While doing this PR, it was found that the access token used was invalid so deletion of any users from Web-Ocis is not happened after clean up. The access token becomes invalid due to Keyclock's backchannel logout feature, which makes the token invalid when the user logs out. So, the next PR will cover that.
More describe in here: link

Related Issue

Motivation and Context

How Has This Been Tested?

test environment:

  • CI
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@nabim777 nabim777 self-assigned this Jun 4, 2024
@nabim777 nabim777 changed the title [tests-only] Refactor on access of token for keyclock [tests-only] [WIP] Restructure data storage for keycloak Jun 11, 2024
@nabim777 nabim777 changed the title [tests-only] [WIP] Restructure data storage for keycloak [tests-only] [WIP] Restructure e2e tests data storage for keycloak Jun 11, 2024
@nabim777 nabim777 force-pushed the keyclock-e2e-storage branch 9 times, most recently from 7c50581 to e4fba60 Compare June 13, 2024 08:37
@nabim777 nabim777 marked this pull request as ready for review June 13, 2024 08:43
@nabim777 nabim777 marked this pull request as draft June 13, 2024 08:44
@nabim777 nabim777 marked this pull request as ready for review June 13, 2024 09:35
@nabim777 nabim777 requested a review from saw-jan June 13, 2024 09:37
@nabim777 nabim777 changed the title [tests-only] [WIP] Restructure e2e tests data storage for keycloak [tests-only] [full-ci] Restructure e2e tests data storage for keycloak Jun 13, 2024
@nabim777
Copy link
Member Author

nabim777 commented Jun 13, 2024

While doing this PR, it was found that the access token used was invalid so deletion of any users from Web-Ocis is not happened after clean up. The access token becomes invalid due to Keyclock's backchannel logout feature, which makes the token invalid when the user logs out. So, the next PR will cover that.
More describe in here: link

tests/e2e/cucumber/steps/ui/adminSettings.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/steps/ui/adminSettings.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/steps/ui/adminSettings.ts Outdated Show resolved Hide resolved
tests/e2e/cucumber/steps/ui/adminSettings.ts Outdated Show resolved Hide resolved
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarcloud bot commented Jun 19, 2024

@nabim777 nabim777 merged commit 71f04b1 into master Jun 19, 2024
3 checks passed
@nabim777 nabim777 deleted the keyclock-e2e-storage branch June 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants