Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added test for open file using /app/open endpoint with different view mode #9954

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[tests-only][full-ci]added test for open file using /app/open endpoint with different view mode #9954

merged 1 commit into from
Sep 3, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

Description

Added test to send post request to /app/open endpoint with different view mode, view_mode=[view | read | write]

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Sep 2, 2024
@PrajwolAmatya PrajwolAmatya mentioned this pull request Sep 2, 2024
Closed
22 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the different-view-mode branch 2 times, most recently from 8f7a979 to c1f1af7 Compare September 3, 2024 03:26
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review September 3, 2024 03:27
saw-jan
saw-jan approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 49c91db into master Sep 3, 2024
4 checks passed
@saw-jan saw-jan deleted the different-view-mode branch September 3, 2024 05:41
ownclouders pushed a commit that referenced this pull request Sep 3, 2024
@saw-jan
Merge pull request #9954 from owncloud/different-view-mode
13d91ce 
[tests-only][full-ci]added test for open file using `/app/open` endpoint with different view mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ishabaral ishabaral Awaiting requested review from ishabaral

@SagarGi SagarGi Awaiting requested review from SagarGi

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrajwolAmatya @saw-jan