Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add tests for checking file info on fake office #9936

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR add tests for checking information of file passed on fakeoffice

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Aug 29, 2024
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-checking-file-info-on-wopi branch 6 times, most recently from af10083 to af30442 Compare August 29, 2024 10:19
@amrita-shrestha amrita-shrestha marked this pull request as ready for review August 29, 2024 10:27
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-checking-file-info-on-wopi branch from af30442 to 43456bf Compare August 30, 2024 04:01
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-checking-file-info-on-wopi branch from 43456bf to 8a467d1 Compare August 30, 2024 05:45
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-checking-file-info-on-wopi branch from 8a467d1 to e444070 Compare August 30, 2024 06:02
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarcloud bot commented Aug 30, 2024

@amrita-shrestha amrita-shrestha merged commit 2e40ec0 into master Aug 30, 2024
4 checks passed
@amrita-shrestha amrita-shrestha deleted the add-tests-for-checking-file-info-on-wopi branch August 30, 2024 06:51
ownclouders pushed a commit that referenced this pull request Aug 30, 2024
…fo-on-wopi

[tests-only][full-ci]Add tests for checking file info on fake office
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants