feat: add exif panel options to web config struct #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mmattel
reviewed
May 29, 2024
services/web/pkg/config/options.go
Outdated
| } | ||
|
|
||
| // SidebarShares are the options for the shares sidebar | ||
| type SidebarShares struct { | ||
| ShowAllOnLoad bool `json:"showAllOnLoad" yaml:"showAllOnLoad" env:"WEB_OPTION_SIDEBAR_SHARES_SHOW_ALL_ON_LOAD" desc:"Sets the list of the (link) shares list in the sidebar to be initially expanded. Default is a collapsed state, only showing the first three shares." introductionVersion:"pre5.0"` | ||
| } | ||
|
|
||
| type SidebarExif struct { | ||
| ShowLocation bool `json:"showLocation" yaml:"showLocation" env:"WEB_OPTION_SIDEBAR_EXIF_SHOW_LOCATION" desc:"Shows or hides the location data in the EXIF sidebar panel." introductionVersion:"6.0"` |
There was a problem hiding this comment.
How does Shows or hides... correspond to the values to be set and any default?
There was a problem hiding this comment.
I added the default and simplified the first part a bit. The value is a bool, I won't add details what true or false does because that's already reflected by the var name.
kulmann
force-pushed
the
web-config-sidebar-exif
branch
from
9f7009f
to
b5c4f16
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is (will be) a new config option in web for hiding the location in the new image info sidebar panel. Adding the option to the web config struct, so that we disabling the location actually works (vanishes from the exposed config.json otherwise).
Types of changes
Checklist: