Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ShareUpdate activity in the space context. #10104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Sep 18, 2024

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the issue-10011 branch 2 times, most recently from 2b9e60f to 3ad5eeb Compare September 19, 2024 07:23
@2403905
Copy link
Contributor Author

2403905 commented Sep 19, 2024

@tboerger The few questions about the activity templates
When a user updates the permission and expiration the ocis emit a single event.
Then the activity uses the template for this event like MessageShareUpdated = l10n.Template("{user} updated {field} for the {resource}")

  1. Can we join the fields enum by comma? permission and expiration => permission, expiration
  2. We translate the activity message template on the server side. Should we also translate the field data that represents as updated field ( permission, expiration) in this case?

Now:
| admin updated expiration, permissions for the New folder |
translated as
| admin оновив expiration, permissions для the New folder |

Could be:
| admin updated expiration, permissions for the New folder |
translated as
| admin оновив термін дії, дозволи для the New folder |

Screenshot 2024-09-19 at 09 46 35

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 19, 2024

@2403905 1,2:yes 🙂

@2403905 2403905 force-pushed the issue-10011 branch 2 times, most recently from 3da79d5 to be6805b Compare September 20, 2024 10:33
Copy link

sonarcloud bot commented Sep 22, 2024

@micbar
Copy link
Contributor

micbar commented Sep 23, 2024

who mentioned @tboerger here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants