Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDN Dashboard helm chart #4412

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

csahithi
Copy link
Contributor

What this PR does and why is it needed

This PR adds the helm chart for SDN dashboard corresponding to various components of ovn-kubernetes

Which issue(s) this PR fixes

Special notes for reviewers

How to verify it

Details to documentation updates

Documentation on how to install the dashboard has been added

Description for the changelog

Does this PR introduce a user-facing change?


@csahithi
Copy link
Contributor Author

@girishmg pls review this PR

@csahithi
Copy link
Contributor Author

ovn-host-controller-dashboard cluster-manager-dashboard north-daemon-dashboard

@coveralls
Copy link

Coverage Status

coverage: 52.59% (+0.07%) from 52.518%
when pulling 584af81 on csahithi:sdn-dashboard
into ef892e1 on ovn-org:master.

@csahithi csahithi force-pushed the sdn-dashboard branch 3 times, most recently from 35e41dc to 331aa5c Compare June 1, 2024 01:56
@girishmg girishmg marked this pull request as ready for review June 1, 2024 15:44
@girishmg girishmg requested a review from a team as a code owner June 1, 2024 15:44
@girishmg girishmg added this to the v1.0.0 milestone Jun 1, 2024
@tssurya
Copy link
Member

tssurya commented Jun 2, 2024

can we please add docs to https://ovn-kubernetes.io/observability/grafana-and-prometheus/ for this? @girishmg this is equally important for us as is the feature ;) you know why.. :D

@tssurya tssurya added area/dashboard kind/feature All issues/PRs that are new features labels Jun 2, 2024
@flavio-fernandes
Copy link
Contributor

Depends on: #4411
Tested it on my helm deployment. Short of requests on doc, /lgtm !

@csahithi csahithi force-pushed the sdn-dashboard branch 2 times, most recently from 8c13047 to 56192dc Compare June 5, 2024 21:25
@github-actions github-actions bot added the kind/documentation All issues related to documentation label Jun 5, 2024
@girishmg
Copy link
Member

girishmg commented Jun 6, 2024

can we please add docs to https://ovn-kubernetes.io/observability/grafana-and-prometheus/ for this? @girishmg this is equally important for us as is the feature ;) you know why.. :D

Absolutely, @csahithi will be working on it next.

Copy link
Member

@girishmg girishmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Flavio also has tested this.

@girishmg
Copy link
Member

girishmg commented Jun 6, 2024

The failure in CI is not related to this PR since this PR just adds an Helm Chart for SDN dashboards, so going to bring this in.

@girishmg girishmg merged commit a8c47e3 into ovn-org:master Jun 6, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/documentation All issues related to documentation kind/feature All issues/PRs that are new features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants