Skip to content

Commit

Permalink
CI: enable tagged-release-images job
Browse files Browse the repository at this point in the history
  • Loading branch information
nixargh committed Sep 5, 2024
1 parent baca7e5 commit 619bb5b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 20 deletions.
38 changes: 19 additions & 19 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@ jobs:

rolling-release-images:
env:
TAG_IMAGE_LATEST: "true"
PROD_IMAGE_NAME: ghcr.io/${GITHUB_REPOSITORY}
VERSION: dev
#needs: [check, unit-test, integration-test-cli, integration-test-k8s, helm-chart-test]
# needs: [check, unit-test, integration-test-cli, integration-test-k8s, helm-chart-test]
needs: [check, unit-test, integration-test-cli, helm-chart-test]
name: Release images
runs-on: ubuntu-latest
Expand All @@ -106,6 +105,24 @@ jobs:
- name: Build and publish docker images
run: make build-publish-image-all

tagged-release-images:
# Only on tags.
if: startsWith(github.ref, 'refs/tags/')
env:
TAG_IMAGE_LATEST: "true"
PROD_IMAGE_NAME: ghcr.io/${GITHUB_REPOSITORY}
# needs: [check, unit-test, integration-test-cli, integration-test-k8s, helm-chart-test]
needs: [check, unit-test, integration-test-cli, helm-chart-test]
name: Tagged release images
runs-on: ubuntu-latest
steps:
- run: echo "VERSION=${GITHUB_REF#refs/*/}" >> ${GITHUB_ENV} # Sets VERSION env var.
- uses: actions/checkout@v4
- name: Docker login
run: docker login ghcr.io -u ${{ github.actor }} -p "${{ secrets.GITHUB_TOKEN }}"
- name: Build and publish docker images
run: make build-publish-image-all

# integration-test-k8s:
# name: Integration test Kubernetes
# runs-on: ubuntu-latest
Expand Down Expand Up @@ -144,20 +161,3 @@ jobs:
# echo "Executing integration tests..."
# export SLOTH_INTEGRATION_KUBE_CONFIG=/tmp/test.kubeconfig
# make ci-integration-k8s


# tagged-release-images:
# # Only on tags.
# if: startsWith(github.ref, 'refs/tags/')
# env:
# PROD_IMAGE_NAME: ghcr.io/${GITHUB_REPOSITORY}
# needs: [check, unit-test, integration-test-cli, integration-test-k8s, helm-chart-test]
# name: Tagged release images
# runs-on: ubuntu-latest
# steps:
# - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> ${GITHUB_ENV} # Sets VERSION env var.
# - uses: actions/checkout@v4
# - name: Docker login
# run: docker login ghcr.io -u ${{ github.actor }} -p "${{ secrets.GITHUB_TOKEN }}"
# - name: Build and publish docker images
# run: make build-publish-image-all
1 change: 0 additions & 1 deletion docker/prod/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ ENV GOARCH=${ARCH}
# Compile.
WORKDIR /src
COPY . .
RUN tree
RUN ./scripts/build/bin/build-raw.sh

# Although we are on an specific architecture (normally linux/amd64) our go binary has been built for
Expand Down

0 comments on commit 619bb5b

Please sign in to comment.