-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ostree-sysroot-deploy: check if deployments are in the same stateroot. #3234
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this, but I am curious what is the use case where all the previous checks have not returned FALSE already. The case where this happens in real-life... We can't depend on changing kargs, this is correct, we use ostree=true in our Android Bootloader images for example.
thanks for the review! See OCPBUGS-30276 just trying to confirm locally this works as intended before moving this out of draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, good catch. Fun bug. I am actually looking forward to us trying to reuse the stateroot stuff more broadly as it's a very powerful thing.
I think it'd be relatively straightforward to do a test case for this in tests/admin-test.sh or so, I can help with that
FWIW I'm also OK adding and shipping this without an additional test, since this looks like a relatively critical bug for that use case and I am very confident the fix is correct. |
f5dcef3
to
a8e5235
Compare
I can see the failure reported in the original issue with the test when I remove my changes:
|
Hmm that one is weird. |
@jmarrero I think this just needs a rebase 🏄 |
Our code currently does not check for stateroot as a differentiator between deployments, however given that we allow multiple stateroots, we should see them as different deployments in the same way we check for kargs for example.