Sync summary times #3233
Sync summary times #3233
Conversation
The skip shell function is for skipping an entire test plan. To skip a single test result, a directive is needed[1]. Without this change, the test suite errors claiming that 2 test plans were provided when fsverity isn't available. 1. https://testanything.org/tap-specification.html#skipping-tests
HTTP servers derive Last-Modified from the modification time of the file. When used in combination with a Cache-Control max-age value, having the modification times match means that caches will consider them expired at the same time. This helps make it more likely that clients won't receive a cached summary and fresh signature or vice versa. This makes more sense to do now that the summary and signature are created in a temporary directory and renamed into place. In the old days where they were created directly in the repo root, it would be strange to change the summary mtime when it wasn't actually modified.
dbnicholson
force-pushed
the
sync-summary-times
branch
from
05b7f6d
to
60f4592
Compare
|
Oof, forgot about |
|
Looks like |
|
Should I just override the failure? It's in a part of code that I didn't touch and I don't know how to get different versions of Possibly |
Yeah, this has bit us at least twice in the past I believe. It's so messy...even if we pick just one target we force everyone to use that specific version which is not great. For now...yes I'll follow up to drop the clang-format from everything except just one OS version. |
I was thinking the same thing. A simple thing would be a wrapper script that runs |
I was looking into an HTTP caching issue in a different project and it occurred to me that there's no reason the
summaryandsummary.sigfiles can't have synchronized mtimes since they're now created in a temporary directory. The first commit is unrelated and I can split it out if preferred.